Rely on inspect.getmembers_static()

python · Bobronium · Sep 27, 2024 · Sep 27, 2024 · Sep 27, 2024 · Sep 27, 2024
commit 5bfea4d299566099b780f0bd17e616b157d41046
@@ -1238,6 +1238,22 @@ def _update_func_cell_for__class__(f, oldcls, newcls):
    return False


+_object_members_values = {
+    value for name, value in
+    (
+        *inspect.getmembers_static(object),
+        *inspect.getmembers_static(object())
+     )
+}
+
+
+def _is_not_object_member(v):
+    try:
+        return v not in _object_members_values
+    except TypeError:
+        return True
+
+
 def _find_inner_functions(obj, seen=None, depth=0):
    if seen is None:
        seen = set()
@@ -1253,22 +1269,14 @@ def _find_inner_functions(obj, seen=None, depth=0):
    if depth > 2:
        return None

-    for attribute in dir(obj):
-        try:
-            value = inspect.getattr_static(obj, attribute)
-        except AttributeError:
-            continue
-        builtin_value = inspect.getattr_static(object, attribute, None)
-        if value is builtin_value:
-            # don't waste time on builtin objects
-            continue
-        if (
-            # isinstance() would trigger `value.__getattribute__("__class__")`
-            type(value) is types.MemberDescriptorType
-            and type not in inspect._static_getmro(type(obj))
-        ):
+    obj_is_type_instance = type in inspect._static_getmro(type(obj))
+    for _, value in inspect.getmembers_static(obj, _is_not_object_member):
+        value_type = type(value)
+        if value_type is types.MemberDescriptorType and not obj_is_type_instance:
            value = value.__get__(obj)
-        if isinstance(value, types.FunctionType):
+            value_type = type(value)
+
+        if value_type is types.FunctionType:
            yield inspect.unwrap(value)
        else:
            yield from _find_inner_functions(value, seen, depth)