Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-58956: Set f_trace on frames with breakpoints after setting a new breakpoint #124454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2024
Merged

gh-58956: Set f_trace on frames with breakpoints after setting a new breakpoint #124454

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a7e07e5
Set f_trace on frames with breakpoints after setting a new breakpoint
gaogaotiantian Sep 24, 2024
bd72ec9
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 24, 2024
5a32d94
Update 2024-09-24-18-16-59.gh-issue-58956.0wFrBR.rst
gaogaotiantian Oct 15, 2024
0cb7fe7
Update Misc/NEWS.d/next/Library/2024-09-24-18-16-59.gh-issue-58956.0w…
gaogaotiantian Oct 15, 2024
9007edf
Merge branch 'main' into fix-module-breakpoint
gaogaotiantian Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
📜🤖 Added by blurb_it.
  • Loading branch information
@blurb-it
blurb-it[bot] authored Sep 24, 2024
commit bd72ec978629d3221c30074e5b5f1e74ec20c32c
1 change: 1 addition & 0 deletions 1 Misc/NEWS.d/next/Library/2024-09-24-18-16-59.gh-issue-58956.0wFrBR.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Setting a :mod:`pdb` breakpoint on a function that's already in the call stack will enable the trace function on that frame so the breakpoint would trigger.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be reworded to make it clearer what the change is (e.g., "Fix bug where..."). They way it's written it's not immediately clear what the old vs new behaviour is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, missed that. Do you think the current news is better?

Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.