Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Adjust build_ubuntu_ssltests job to use cache for the correct OS version#124403

Merged
zware merged 1 commit intopython:mainpython/cpython:mainfrom
zware:ubuntu_ci_cache_fixupzware/cpython:ubuntu_ci_cache_fixupCopy head branch name to clipboard
Sep 25, 2024
Merged

Adjust build_ubuntu_ssltests job to use cache for the correct OS version#124403
zware merged 1 commit intopython:mainpython/cpython:mainfrom
zware:ubuntu_ci_cache_fixupzware/cpython:ubuntu_ci_cache_fixupCopy head branch name to clipboard

Conversation

@zware
Copy link
Member

@zware zware commented Sep 24, 2024

This is a forward-port of the fix in GH-123699 to ensure that the cached OpenSSL builds are tagged with the OS version.

@zware zware added skip issue skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 24, 2024
@zware zware self-assigned this Sep 24, 2024
@zware zware mentioned this pull request Sep 24, 2024
Merged
hugovk
hugovk approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zware zware merged commit 54dd77f into python:main Sep 25, 2024
@zware zware deleted the ubuntu_ci_cache_fixup branch September 25, 2024 01:27
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 25, 2024

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2024
@zware @miss-islington
Adjust build_ubuntu_ssltests job to use cache for the correct OS vers…
9815e10 
…ion (pythonGH-124403)

(cherry picked from commit 54dd77f)

Co-authored-by: Zachary Ware <zach@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Sep 25, 2024

GH-124481 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 25, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2024
@zware @miss-islington
Adjust build_ubuntu_ssltests job to use cache for the correct OS vers…
fa3be35 
…ion (pythonGH-124403)

(cherry picked from commit 54dd77f)

Co-authored-by: Zachary Ware <zach@python.org>
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 25, 2024

Sorry, @zware, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 54dd77fb8c880d7655fffab934978e277b4275fe 3.11

@bedevere-app
Copy link

bedevere-app bot commented Sep 25, 2024

GH-124482 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 25, 2024
zware added a commit to zware/cpython that referenced this pull request Sep 25, 2024
@zware
[3.11] Adjust build_ubuntu_ssltests job to use cache for the correct …
27fed47 
…OS version (pythonGH-124403)

(cherry picked from commit 54dd77f)

Co-authored-by: Zachary Ware <zach@python.org>
Yhg1s pushed a commit that referenced this pull request Sep 26, 2024
@miss-islington @zware
[3.13] Adjust build_ubuntu_ssltests job to use cache for the correct …
c5d0972 
…OS version (GH-124403) (#124481)

Adjust build_ubuntu_ssltests job to use cache for the correct OS version (GH-124403)
(cherry picked from commit 54dd77f)

Co-authored-by: Zachary Ware <zach@python.org>
@zware zware removed the needs backport to 3.11 only security fixes label Oct 22, 2024
@hugovk hugovk mentioned this pull request Oct 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

@zware zware

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zware @hugovk
Morty Proxy This is a proxified and sanitized view of the page, visit original site.