Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-123085: _compile_importlib: Avoid copying sources before compilation #124131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2024
Merged

gh-123085: _compile_importlib: Avoid copying sources before compilation #124131

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cade8d2
_compile_importlib: Avoid copying sources before compilation
encukou Sep 16, 2024
5455d06
Remove debug print
encukou Sep 17, 2024
211b436
Add comment
encukou Sep 17, 2024
8cd8fe9
Rely on pathlib.Path.glob for simplicity.
jaraco Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions 15 Lib/test/test_importlib/resources/test_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,18 +134,17 @@ def test_implicit_files_submodule(self):
def _compile_importlib(self):
"""
Make a compiled-only copy of the importlib resources package.

Currently only code is copied, as importlib resources doesn't itself
have any resources.
"""
bin_site = self.fixtures.enter_context(os_helper.temp_dir())
c_resources = pathlib.Path(bin_site, 'c_resources')
sources = pathlib.Path(resources.__file__).parent
shutil.copytree(sources, c_resources, ignore=lambda *_: ['__pycache__'])

for dirpath, _, filenames in os.walk(c_resources):
for filename in filenames:
source_path = pathlib.Path(dirpath) / filename
cfile = source_path.with_suffix('.pyc')
py_compile.compile(source_path, cfile)
pathlib.Path.unlink(source_path)

for source_path in sources.glob('**/*.py'):
c_path = c_resources.joinpath(source_path.relative_to(sources)).with_suffix('.pyc')
py_compile.compile(source_path, c_path)
self.fixtures.enter_context(import_helper.DirsOnSysPath(bin_site))

def test_implicit_files_with_compiled_importlib(self):
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.