Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-85453: Improve class reference links on datetime.rst #123980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
Loading
from
Open

gh-85453: Improve class reference links on datetime.rst #123980

wants to merge 10 commits into from
+24 −24

Conversation

uatach
Copy link
Contributor

@uatach uatach commented Sep 11, 2024 •
edited by github-actions bot
Loading

Another pull request based on PR #21447, this one is focused on improving class reference links.

📚 Documentation preview 📚: https://cpython-previews--123980.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 11, 2024
@bedevere-app bedevere-app bot mentioned this pull request Sep 11, 2024
Open
uatach
uatach commented Sep 11, 2024
View reviewed changes
Doc/library/datetime.rst Outdated Show resolved Hide resolved
uatach
uatach commented Oct 19, 2024
View reviewed changes
Doc/library/datetime.rst Show resolved Hide resolved
@uatach uatach requested a review from erlend-aasland October 28, 2024 21:33
erlend-aasland
erlend-aasland reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the rendered preview with the existing docs, and there are still quite a few places where I think the link density is too high within a paragraph. I'll jot them down tomorrow or the day after.

Doc/library/datetime.rst Outdated Show resolved Hide resolved
Doc/library/datetime.rst Outdated Show resolved Hide resolved
Doc/library/datetime.rst Outdated Show resolved Hide resolved
@uatach
Copy link
Contributor Author

uatach commented Dec 2, 2024

I compared the rendered preview with the existing docs, and there are still quite a few places where I think the link density is too high within a paragraph. I'll jot them down tomorrow or the day after.

@erlend-aasland did you have a chance to look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@erlend-aasland erlend-aasland erlend-aasland left review comments

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uatach @picnixz @erlend-aasland
Morty Proxy This is a proxified and sanitized view of the page, visit original site.