Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix "The Matrix" movie release year in typing.rst #123965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix "The Matrix" movie release year in typing.rst #123965

merged 1 commit into from
Sep 11, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 11, 2024 •
edited by github-actions bot
Loading

I am really sorry for doing this, but this really bothered me while reading the docs.

The Matrix was released in 1999, not 1992. Link: https://en.wikipedia.org/wiki/The_Matrix

Feel free to ignore this PR.

📚 Documentation preview 📚: https://cpython-previews--123965.org.readthedocs.build/

@sobolevn sobolevn added docs Documentation in the Doc dir skip news labels Sep 11, 2024
JelleZijlstra
JelleZijlstra approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type checkers should really catch this.

@AlexWaygood
Copy link
Member

Type checkers should really catch this.

@carljm: "We should add this as a feature to red-knot"

@sobolevn sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.12 only security fixes labels Sep 11, 2024
@sobolevn sobolevn merged commit 3bd942f into python:main Sep 11, 2024
33 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2024
@sobolevn @miss-islington
Fix "The Matrix" movie release year in typing.rst (pythonGH-123965)
60c6776 
(cherry picked from commit 3bd942f)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Sep 11, 2024

GH-123966 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 11, 2024
@sobolevn
Copy link
Member Author

Thanks! I will schedule a 3.13 backport, it is up to release manager to merge it or close it.

изображение

Yhg1s pushed a commit that referenced this pull request Sep 23, 2024
@miss-islington @sobolevn
[3.13] Fix "The Matrix" movie release year in typing.rst (GH-123965) (
bbec2ea 
#123966)

Fix "The Matrix" movie release year in `typing.rst` (GH-123965)
(cherry picked from commit 3bd942f)

Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @AlexWaygood @JelleZijlstra
Morty Proxy This is a proxified and sanitized view of the page, visit original site.