Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-118761: Speedup pathlib import by deferring shutil #123520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 1, 2024
Merged

gh-118761: Speedup pathlib import by deferring shutil #123520

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59b5bd0
Speedup pathlib import by deffering shutil
danielhollas Aug 30, 2024
3957097
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 31, 2024
2a180bc
Merge branch 'main' into speedup-pathlib
danielhollas Aug 31, 2024
496e0ac
Update Lib/pathlib/_local.py
danielhollas Aug 31, 2024
889836d
Delete News entry
danielhollas Aug 31, 2024
0067d84
remove path keyword
danielhollas Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions 5 Lib/pathlib/_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import operator
import os
import posixpath
import shutil
import sys
from glob import _StringGlobber
from itertools import chain
Expand Down Expand Up @@ -824,7 +823,9 @@ def rmdir(self):
"""
os.rmdir(self)

_rmtree = shutil.rmtree
def _rmtree(self):
import shutil
danielhollas marked this conversation as resolved.
Show resolved Hide resolved
shutil.rmtree(path=self)
barneygale marked this conversation as resolved.
Show resolved Hide resolved
hugovk marked this conversation as resolved.
Show resolved Hide resolved
danielhollas marked this conversation as resolved.
Show resolved Hide resolved

def rename(self, target):
"""
Expand Down
1 change: 1 addition & 0 deletions 1 Misc/NEWS.d/next/Library/2024-08-31-11-12-49.gh-issue-118761.Ai_Ma1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Speed up pathlib import time by 15% by deferring shutil import.
picnixz marked this conversation as resolved.
Show resolved Hide resolved
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.