Fix leak in PyInitConfig_GetStrList()

+ some extra edits
python · vstinner · Sep 3, 2024 · Oct 1, 2023 · Aug 30, 2024 · Aug 30, 2024
commit 7e3e1aa52b94e804f6b07efb86d4c8328f1ceeca
@@ -1682,6 +1682,9 @@ null-terminated UTF-8 encoded string.
   * Set *\*value*, and return ``0`` on success.
   * Set an error in *config* and return ``-1`` on error.

+   *\*value* can be set to ``NULL`` if the option is an optional string and the
+   option is unset.
+
   On success, the string must be released with ``free(value)``.



@@ -3631,7 +3631,8 @@ PyInitConfig_GetStr(PyInitConfig *config, const char *name, char **value)
    }

    if (spec->type != PyConfig_MEMBER_WSTR
-            && spec->type != PyConfig_MEMBER_WSTR_OPT) {
+        && spec->type != PyConfig_MEMBER_WSTR_OPT)
+    {
        initconfig_set_error(config, "config option type is not string");
        return -1;
    }
@@ -3676,7 +3677,7 @@ PyInitConfig_GetStrList(PyInitConfig *config, const char *name, size_t *length,
    for (Py_ssize_t i=0; i < list->length; i++) {
        (*items)[i] = wstr_to_utf8(config, list->items[i]);
        if ((*items)[i] == NULL) {
-            free(*items);
+            PyInitConfig_FreeStrList(i, *items);
            return -1;
        }
    }