Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-120754: Refactor I/O modules to stash whole stat result rather than individual members #123412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 18, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply review changes for _pyio _blkszie
  • Loading branch information
cmaloney committed Aug 29, 2024
commit 8f5cfe434863e4b4160d3991b3ae4e920554d477
13 changes: 8 additions & 5 deletions 13 Lib/_pyio.py
Original file line number Diff line number Diff line change
Expand Up @@ -1614,11 +1614,14 @@ def __repr__(self):

@property
def _blksize(self):
if self._stat_atopen:
res = getattr(self._stat_atopen, "st_blksize", 0)

# WASI sets blksize to 0
return res if res > 0 else DEFAULT_BUFFER_SIZE
if self._stat_atopen is None:
return DEFAULT_BUFFER_SIZE

blksize = getattr(self._stat_atopen, "st_blksize", 0)
# WASI sets blsize to 0
if not blksize:
return DEFAULT_BUFFER_SIZE
return blksize

def _checkReadable(self):
if not self._readable:
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.