Apply suggestions from code review

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
python · hugovk · Aug 7, 2024 · Aug 5, 2024 · Aug 6, 2024 · Aug 6, 2024
commit 07cffca9a441c6f696e2133dd5139ea7b4d5e26e
diff --git a/Lib/pprint.py b/Lib/pprint.py
@@ -186,7 +186,7 @@ def _format(self, object, stream, indent, allowance, context, level):
        if len(rep) > max_width:
            p = self._dispatch.get(type(object).__repr__, None)
            # Lazy import to improve module import time
-            import dataclasses as _dataclasses
+            from dataclasses import is_dataclass

            if p is not None:
                context[objid] = 1
@@ -207,11 +207,11 @@ def _format(self, object, stream, indent, allowance, context, level):

    def _pprint_dataclass(self, object, stream, indent, allowance, context, level):
        # Lazy import to improve module import time
-        import dataclasses as _dataclasses
+        from dataclasses import fields as dataclass_fields

        cls_name = object.__class__.__name__
        indent += len(cls_name) + 1
-        items = [(f.name, getattr(object, f.name)) for f in _dataclasses.fields(object) if f.repr]
+        items = [(f.name, getattr(object, f.name)) for f in dataclass_fields(object) if f.repr]
        stream.write(cls_name + '(')
        self._format_namespace_items(items, stream, indent, allowance, context, level)
        stream.write(')')