Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-118943: Remove 'regen-jit' from the 'regen-all' make target #122602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 8, 2024
Merged

gh-118943: Remove 'regen-jit' from the 'regen-all' make target #122602

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a593b7c
gh-118943: Remove 'regen-jit' from the 'regen-all' make target
hroncok Aug 2, 2024
73cfd83
fixup Consistency
hroncok Aug 3, 2024
9b18b68
fixup Call make regen-jit from the JIT workflow
hroncok Aug 3, 2024
e21a156
Check for changes in regen-jit
hroncok Aug 3, 2024
c41b712
Revert the CI changes and user-facing echo
hroncok Aug 5, 2024
3b49147
Update Misc/NEWS.d/next/Build/2024-08-02-12-59-15.gh-issue-118943.vZQ…
hroncok Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert the CI changes and user-facing echo
  • Loading branch information
@hroncok
hroncok committed Aug 5, 2024
commit c41b712f87f44b742fd76d72c407ad1382cb6b5e
20 changes: 1 addition & 19 deletions 20 .github/workflows/jit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,27 +32,9 @@ jobs:
timeout-minutes: 90
steps:
- uses: actions/checkout@v4
- name: Configure tier two interpreter
run: |
./configure --enable-experimental-jit=interpreter --with-pydebug
- name: Regen JIT
run: |
make regen-jit
- name: Check for changes
run: |
git add -u
changes=$(git status --porcelain)
# Check for changes in regenerated files
if test -n "$changes"; then
echo "Generated files not up to date."
echo "Perhaps you forgot to run make regen-jit. ;)"
echo "$changes"
echo ""
git diff --staged || true
exit 1
fi
- name: Build tier two interpreter
run: |
./configure --enable-experimental-jit=interpreter --with-pydebug
make all --jobs 4
- name: Test tier two interpreter
run: |
Expand Down
2 changes: 1 addition & 1 deletion 2 Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1668,7 +1668,7 @@ regen-all: regen-cases regen-typeslots \
regen-test-levenshtein regen-global-objects
@echo
@echo "Note: make regen-stdlib-module-names, make regen-limited-abi, "
@echo "make regen-configure, make regen-sbom, make regen-jit, and make regen-unicodedata should be run manually"
@echo "make regen-configure, make regen-sbom, and make regen-unicodedata should be run manually"

############################################################################
# Special rules for object files
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.