Add also test for non-truncated large body.

python · serhiy-storchaka · May 23, 2024 · May 23, 2024 · May 23, 2024 · f097fada1be22d44ca59cf4bb0f74bcb5f331c66
commit f097fada1be22d44ca59cf4bb0f74bcb5f331c66
diff --git a/Lib/test/test_httplib.py b/Lib/test/test_httplib.py
@@ -1440,15 +1440,48 @@ def test_large_content_length(self):
        serv = socket.create_server((HOST, 0))
        self.addCleanup(serv.close)

+        def run_server():
+            [conn, address] = serv.accept()
+            with conn:
+                while conn.recv(1024):
+                    conn.sendall(
+                        b"HTTP/1.1 200 Ok\r\n"
+                        b"Content-Length: %d\r\n"
+                        b"\r\n" % size)
+                    conn.sendall(b'A' * (size//3))
+                    conn.sendall(b'B' * (size - size//3))
+
+        thread = threading.Thread(target=run_server)
+        thread.start()
+        self.addCleanup(thread.join, 1.0)
+
+        conn = client.HTTPConnection(*serv.getsockname())
+        try:
+            for w in range(15, 27):
+                size = 1 << w
+                conn.request("GET", "/")
+                with conn.getresponse() as response:
+                    self.assertEqual(len(response.read()), size)
+        finally:
+            conn.close()
+            thread.join(1.0)
+
+    def test_large_content_length_truncated(self):
+        serv = socket.create_server((HOST, 0))
+        self.addCleanup(serv.close)
+
        def run_server():
            while True:
                [conn, address] = serv.accept()
                with conn:
                    conn.recv(1024)
                    if not size:
                        break
-                    body = b"HTTP/1.1 200 Ok\r\nContent-Length: %d\r\n\r\nText" % size
-                    conn.sendall(body)
+                    conn.sendall(
+                        b"HTTP/1.1 200 Ok\r\n"
+                        b"Content-Length: %d\r\n"
+                        b"\r\n"
+                        b"Text" % size)

        thread = threading.Thread(target=run_server)
        thread.start()
@@ -1467,7 +1500,7 @@ def run_server():
            size = 0
            conn.request("GET", "/")
            conn.close()
-            thread.join()
+            thread.join(1.0)

    def test_putrequest_override_domain_validation(self):
        """