Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Rename typing._collect_parameters #118900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 10, 2024
Merged

Rename typing._collect_parameters #118900

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1020121
Rename typing._collect_parameters
JelleZijlstra May 10, 2024
d7a7c0c
Readd as deprecated
JelleZijlstra May 10, 2024
b472e26
Merge remote-tracking branch 'upstream/main' into collectparams
JelleZijlstra May 10, 2024
0afb4a7
Better test
JelleZijlstra May 10, 2024
b022ddc
fix stacklevel
JelleZijlstra May 10, 2024
388d56b
Update Lib/test/test_typing.py
JelleZijlstra May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Better test
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed May 10, 2024
commit 0afb4a7eedf0e6826f7ed5900f4e2202726f4fbd
5 changes: 3 additions & 2 deletions 5 Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
import weakref
import types

from test.support import captured_stderr, cpython_only, infinite_recursion, requires_docstrings
from test.support import captured_stderr, cpython_only, infinite_recursion, requires_docstrings, import_helper
from test.typinganndata import ann_module695, mod_generics_cache, _typed_dict_helper


Expand Down Expand Up @@ -6353,8 +6353,9 @@ def test_deprecation_for_no_type_params_passed_to__evaluate(self):
self.assertEqual(cm.filename, __file__)

def test_collect_parameters(self):
typing = import_helper.import_fresh_module("typing")
with self.assertWarns(DeprecationWarning):
from typing import _collect_parameters
typing._collect_parameters


@lru_cache()
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.