Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-118189: Revert accidentally added incl.tar #118190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2024
Merged

gh-118189: Revert accidentally added incl.tar #118190

merged 1 commit into from
Apr 23, 2024

Conversation

arhadthedev
Copy link
Member

@arhadthedev arhadthedev commented Apr 23, 2024 •
edited by bedevere-app bot
Loading

This is a follow-up to gh-118159.

Include/incl.tar is a full copy of Include. It seems to be added by accident so this PR deletes it back.

No NEWS entry because the file was added yesterday with no backports.

/cc @gvanrossum as an author of the parent PR.

@arhadthedev arhadthedev changed the title github-118189: Revert accidentally added incl.tar gh-118189: Revert accidentally added incl.tar Apr 23, 2024
@bedevere-app bedevere-app bot mentioned this pull request Apr 23, 2024
Closed
@JelleZijlstra JelleZijlstra enabled auto-merge (squash) April 23, 2024 17:11
@JelleZijlstra JelleZijlstra merged commit 2584082 into python:main Apr 23, 2024
36 checks passed
@arhadthedev arhadthedev deleted the incl-tar-deletion branch April 23, 2024 17:38
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x has failed when building commit 2584082.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1380/builds/66) and take a look at the build logs.
  4. Check if the failure is related to this commit (2584082) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1380/builds/66

Failed tests:

  • test_posix

Failed subtests:

  • test_confstr - test.test_posix.PosixTester.test_confstr

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/4FED991E-7280-4D2F-B63A-C7FECDE66EAD/data/Containers/Bundle/Application/0809D9E4-34B6-4223-A3AD-079D76671D9D/iOSTestbed.app/python/lib/python3.13/test/test_posix.py", line 569, in test_confstr
    self.assertEqual(len(posix.confstr("CS_PATH")) > 0, True)
                         ~~~~~~~~~~~~~^^^^^^^^^^^
ValueError: unrecognized configuration name

@JelleZijlstra
Copy link
Member

Looks unrelated

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL7 LTO + PGO 3.x has failed when building commit 2584082.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/96/builds/7336) and take a look at the build logs.
  4. Check if the failure is related to this commit (2584082) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/96/builds/7336

Failed tests:

  • test_capi

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 3, done.        
remote: Counting objects:  33% (1/3)        
remote: Counting objects:  66% (2/3)        
remote: Counting objects: 100% (3/3)        
remote: Counting objects: 100% (3/3), done.        
remote: Compressing objects:  33% (1/3)        
remote: Compressing objects:  66% (2/3)        
remote: Compressing objects: 100% (3/3)        
remote: Compressing objects: 100% (3/3), done.        
remote: Total 3 (delta 0), reused 2 (delta 0), pack-reused 0        
From https://github.com/python/cpython
 * branch            main       -> FETCH_HEAD
Note: checking out '258408239a4fe8a14919d81b73a16e2cfa374050'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at 2584082... gh-118189: Revert accidentally added incl.tar (#118190)
Switched to and reset branch 'main'

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make[2]: [Makefile:3101: clean-retain-profile] Error 1 (ignored)

make: *** [Makefile:2232: buildbottest] Error 2

@gvanrossum
Copy link
Member

Sorry! git rookie mistake. :-( Thanks for cleaning up my mess.

@mhsmith
Copy link
Member

mhsmith commented Apr 23, 2024 

    self.assertEqual(len(posix.confstr("CS_PATH")) > 0, True)
                         ~~~~~~~~~~~~~^^^^^^^^^^^
ValueError: unrecognized configuration name

@freakboy3742: This seems to be happening at random in about 1 in 10 of the iOS buildbot runs.

@freakboy3742 freakboy3742 mentioned this pull request Apr 23, 2024
Closed
@freakboy3742
Copy link
Contributor

I've opened #118201 to track the intermittent iOS build failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arhadthedev @bedevere-bot @JelleZijlstra @gvanrossum @mhsmith @freakboy3742
Morty Proxy This is a proxified and sanitized view of the page, visit original site.