Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Docs: replace Harry Potter reference with Monty Python #118130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Apr 21, 2024

Harry Potter's author has publicly expressed opinions that contribute to the unsafety of transgender people.

I have no doubt that this reference was added in good faith, especially considering that it was contributed 17 years ago, shortly after Twitter's inception (and presumably before JK Rowling signed up), but I think that keeping it around now would send off the wrong message to trans folks that this community doesn't care about them.

I stumbled upon this particular instance simply by reading docs, but I didn't find more.

Luke and Leia seemed like a good replacement here as another mix-gendered pair of main characters from an extremely popular franchise with names that start with the same letter.


📚 Documentation preview 📚: https://cpython-previews--118130.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 21, 2024
@hugovk hugovk changed the title DOC: replace Harry Potter reference with Star Wars Docs: replace Harry Potter reference with Star Wars Apr 21, 2024
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something Monty Pythonesque would also fit, and I think examples with different first letters (spam and eggs?) would make the sorting issue more obvious.

Doc/library/doctest.rst Outdated Show resolved Hide resolved
@hugovk hugovk added the needs backport to 3.12 only security fixes label Apr 21, 2024
@neutrinoceros
Copy link
Contributor Author

I'm open to suggestions, I'm not well versed in Monty Python stuff !

@hugovk
Copy link
Member

hugovk commented Apr 21, 2024

Spam and eggs is a popular one:

From this sketch:

@neutrinoceros neutrinoceros changed the title Docs: replace Harry Potter reference with Star Wars Docs: replace Harry Potter reference with Monty Python Apr 21, 2024
@neutrinoceros
Copy link
Contributor Author

@hugovk done !

@barneygale barneygale merged commit 1446024 into python:main Apr 21, 2024
@miss-islington-app
Copy link

Thanks @neutrinoceros for the PR, and @barneygale for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 21, 2024
(cherry picked from commit 1446024)

Co-authored-by: Clément Robert <cr52@protonmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 21, 2024

GH-118135 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 21, 2024
barneygale pushed a commit that referenced this pull request Apr 21, 2024
) (#118135)

Docs: replace Harry Potter reference with Monty Python (GH-118130)
(cherry picked from commit 1446024)

Co-authored-by: Clément Robert <cr52@protonmail.com>
@neutrinoceros neutrinoceros deleted the doc/doctest_no_hp branch April 21, 2024 18:33
@fzfking

This comment was marked as abuse.

@python python locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.