gh-117953: Refactor Import Machinery Code for Extension Modules#118116

Closed

ericsnowcurrently wants to merge 40 commits intopython:mainfrom

ericsnowcurrently:split-up-load-dynamic-module-with-spec

Commits on Apr 16, 2024

Factor out _PyImport_RunDynamicModule().
ericsnowcurrently
committed
cc67849
Copy full SHA for cc67849
Drop _PyImport_LoadDynamicModuleWithSpec().
ericsnowcurrently
committed
2e5ecde
Copy full SHA for 2e5ecde
Add an assert.
ericsnowcurrently
committed
b810cd8
Copy full SHA for b810cd8
Factor out fix_up_extension_for_interpreter().
ericsnowcurrently
committed
8d0ef38
Copy full SHA for 8d0ef38
Do _extensions_cache_set() first.
ericsnowcurrently
committed
7f930cc
Copy full SHA for 7f930cc
Calculate path_bytes ahead of time.
ericsnowcurrently
committed
1ffeaef
Copy full SHA for 1ffeaef
Move the audit entry to _imp_create_dynamic_impl().
ericsnowcurrently
committed
7500285
Copy full SHA for 7500285
_Py_ext_module_loader_info_from_spec() -> _Py_ext_module_loader_info_init_from_spec()
ericsnowcurrently
committed
3c0b170
Copy full SHA for 3c0b170
Add info.newcontext.
ericsnowcurrently
committed
02e24cc
Copy full SHA for 02e24cc
Split up _PyImport_RunDynamicModule() along cross-interpreter-safe boundaries.
ericsnowcurrently
committed
ba5ffa7
Copy full SHA for ba5ffa7
Drop _PyImport_RunDynamicModule().
ericsnowcurrently
committed
b895966
Copy full SHA for b895966
Always close the file handle.
ericsnowcurrently
committed
76fa273
Copy full SHA for 76fa273

Commits on Apr 18, 2024

Revert the fclose() change.
ericsnowcurrently
committed
1e936c5
Copy full SHA for 1e936c5
Factor out create_dynamic().
ericsnowcurrently
committed
6bb07b9
Copy full SHA for 6bb07b9
Drop _PyImport_FixupExtensionObject().
ericsnowcurrently
committed
2705e65
Copy full SHA for 2705e65
Move setting __file__ to fix_up_extension().
ericsnowcurrently
committed
98d8b4b
Copy full SHA for 98d8b4b
Pass tstate through to fix_up_extension().
ericsnowcurrently
committed
ddf1135
Copy full SHA for ddf1135
Add a note about _PyImport_FixupBuiltin().
ericsnowcurrently
committed
694a763
Copy full SHA for 694a763
Always expect a valid modules dict passed to fix_up_extension().
ericsnowcurrently
committed
72e0d73
Copy full SHA for 72e0d73
Factor out reload_singlephase_extension().
ericsnowcurrently
committed
3f14a67
Copy full SHA for 3f14a67
res.singlephase -> res.kind
ericsnowcurrently
committed
b5f5868
Copy full SHA for b5f5868
Factor out _extensions_cache_init().
ericsnowcurrently
committed
a5f7535
Copy full SHA for a5f7535
Factor out _extensions_cache_find_unlocked().
ericsnowcurrently
committed
e8d674a
Copy full SHA for e8d674a
Use _PyImport_RunModInitFunc() in create_builtin().
ericsnowcurrently
committed
27b365d
Copy full SHA for 27b365d
Clean up _PyImport_FixupBuiltin().
ericsnowcurrently
committed
5128702
Copy full SHA for 5128702
Add some asserts to _PyImport_RunModInitFunc().
ericsnowcurrently
committed
aaec360
Copy full SHA for aaec360
Drop the replace arg to _extensions_cache_set().
ericsnowcurrently
committed
f97671e
Copy full SHA for f97671e
Check the module returned by import_find_extension() to ensure single-phase init.
ericsnowcurrently
committed
2366983
Copy full SHA for 2366983

Commits on Apr 19, 2024

Allow mod->md_def to be NULL.
ericsnowcurrently
committed
d5039ea
Copy full SHA for d5039ea
Call _PyImport_RunModInitFunc() in reload_singlephase_extension().
ericsnowcurrently
committed
67d217b
Copy full SHA for 67d217b
res->err is an array, not just a pointer.
ericsnowcurrently
committed
9e40287
Copy full SHA for 9e40287
Factor out import_run_extension() (and drop create_dynamic()).
ericsnowcurrently
committed
b8c2a1d
Copy full SHA for b8c2a1d
Factor out update_extension_cache() and drop fix_up_extension_for_interpreter().
ericsnowcurrently
committed
967c649
Copy full SHA for 967c649
We already know the def is okay.
ericsnowcurrently
committed
aecf56c
Copy full SHA for aecf56c
Revive fix_up_extension_for_interpreter().
ericsnowcurrently
committed
0d03d23
Copy full SHA for 0d03d23
Add a distinct _Py_ext_module_loader_info.path (and old path -> filename).
ericsnowcurrently
committed
cace102
Copy full SHA for cace102
Do not call update_extensions_cache() in fix_up_extension().
ericsnowcurrently
committed
3cf0db0
Copy full SHA for 3cf0db0
Let the modules arg to fix_up_extension_for_interpreter() be NULL.
ericsnowcurrently
committed
9b3088a
Copy full SHA for 9b3088a
Let the caller of update_extensions_cache() decide if m_copy should be populated.
ericsnowcurrently
committed
4ac1644
Copy full SHA for 4ac1644
Fix the update_extensions_cache() signature.
ericsnowcurrently
committed
393a177
Copy full SHA for 393a177