Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-117531: Unblock getters after non-immediate queue shutdown #117532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 10, 2024
Merged

gh-117531: Unblock getters after non-immediate queue shutdown #117532

merged 10 commits into from
Apr 10, 2024

Conversation

EpicWink
Copy link
Contributor

@EpicWink EpicWink commented Apr 4, 2024 •
edited by bedevere-app bot
Loading

@EpicWink EpicWink requested a review from rhettinger as a code owner April 4, 2024 02:07
@bedevere-app bedevere-app bot mentioned this pull request Apr 4, 2024
Closed
@EpicWink EpicWink force-pushed the queue-shutdown-unblock-get branch from 8bb6fae to 5d490b3 Compare April 4, 2024 02:09
@EpicWink EpicWink mentioned this pull request Apr 4, 2024
Merged
@rhettinger rhettinger removed their request for review April 4, 2024 02:16
YvesDup
YvesDup reviewed Apr 4, 2024
View reviewed changes
Lib/test/test_queue.py Outdated Show resolved Hide resolved
YvesDup
YvesDup reviewed Apr 4, 2024
View reviewed changes
Lib/test/test_queue.py Outdated Show resolved Hide resolved
@YvesDup
Copy link
Contributor

YvesDup commented Apr 6, 2024

Regarding my last comments, docstring of shutdown method (and related documentation - I didn't check) must be modified about 'blocked callers'.

YvesDup
YvesDup reviewed Apr 8, 2024
View reviewed changes
Lib/queue.py Show resolved Hide resolved
@YvesDup
Copy link
Contributor

YvesDup commented Apr 8, 2024 •
edited
Loading

I approved the last commits and I'm waiting for the last comment to be approve (or not).

@YvesDup
Copy link
Contributor

YvesDup commented Apr 9, 2024

I approve

@YvesDup
Copy link
Contributor

YvesDup commented Apr 10, 2024

@gvanrossum Sorry, I forget to tell you that I've approved

@gvanrossum gvanrossum merged commit 6bc0b33 into python:main Apr 10, 2024
@EpicWink EpicWink deleted the queue-shutdown-unblock-get branch April 11, 2024 01:06
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@EpicWink @diegorusso
pythongh-117531: Unblock getters after non-immediate queue shutdown (p…
56927d4 
…ython#117532)

(This is a small tweak of the original pythongh-104750 which added shutdown.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YvesDup YvesDup YvesDup left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EpicWink @YvesDup @gvanrossum
Morty Proxy This is a proxified and sanitized view of the page, visit original site.