Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-112087: Make list.sort to be thread-safe for PEP 703. #116553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2024
Merged

gh-112087: Make list.sort to be thread-safe for PEP 703. #116553

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a55c7d
gh-112087: Make list.sort to be threaf-safe for PEP 703.
corona10 Mar 9, 2024
d868d15
Uuse atmoic_store_tpr for self->ob_item = NULL;
corona10 Mar 10, 2024
df6fe4f
Use more atomic operations
corona10 Mar 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Uuse atmoic_store_tpr for self->ob_item = NULL;
  • Loading branch information
@corona10
corona10 committed Mar 10, 2024
commit d868d153db2a6a2375c10824cad94c986726f001
2 changes: 1 addition & 1 deletion 2 Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2624,7 +2624,7 @@ list_sort_impl(PyListObject *self, PyObject *keyfunc, int reverse)
saved_ob_item = self->ob_item;
saved_allocated = self->allocated;
Py_SET_SIZE(self, 0);
self->ob_item = NULL;
FT_ATOMIC_STORE_PTR_RELEASE(self->ob_item, NULL);
colesbury marked this conversation as resolved.
Show resolved Hide resolved
self->allocated = -1; /* any operation will reset it to >= 0 */

if (keyfunc == NULL) {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.