bpo-35781: Changed references to deprecated 'warn' method in logging documentation in favour of 'warning' #11654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
I don't think a NEWS entry is needed for this change. Please update the title of the PR to something appropriate to the change like "change deprecated logging.warn to logging.warning in docs" so that someone will be interested to look into this.
Thanks for your contribution :)
A NEWS entry isn't needed for this change.
vsajip
approved these changes
Jan 23, 2019
|
Thanks @yuji38kwmt for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 23, 2019
…documentation in favour of 'warning' (pythonGH-11654) (cherry picked from commit cda73a5) Co-authored-by: yuji38kwmt <yuji38kwmt@yahoo.co.jp>
|
GH-11657 is a backport of this pull request to the 3.7 branch. |
vsajip
pushed a commit
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35781