-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
[3.7] bpo-20239: Allow repeated deletion of unittest.mock.Mock attributes (GH-11057) #11629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ythonGH-11057) * Allow repeated deletion of unittest.mock.Mock attributes * fixup! Allow repeated deletion of unittest.mock.Mock attributes * fixup! fixup! Allow repeated deletion of unittest.mock.Mock attributes (cherry picked from commit 222d303) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal and @cjw296: Status check is done, and it's a success ✅ . |
|
This is a false positive for this PR. In investigating the real reason. |
Thanks. It's interesting that @miss-islington said everything was okay, I wonder if this build has known intermittent failures? |
@cjw296 This message comes from the buildbots, so there are a trillion more possible failures there as the commits run in lots of different platform and architectures. There are race conditions and false positives. That's why we made this message they way I'd written. The tests that are run in GitHub are only ran on a very limited subset of configurations. That's why everything was ok here but not on the buildbots. |
|
Opened https://bugs.python.org/issue35795 to track the buildbot issue that is confirmed is not related to this PR. |
Allow repeated deletion of unittest.mock.Mock attributes
fixup! Allow repeated deletion of unittest.mock.Mock attributes
fixup! fixup! Allow repeated deletion of unittest.mock.Mock attributes
(cherry picked from commit 222d303)
Co-authored-by: Pablo Galindo Pablogsal@gmail.com
https://bugs.python.org/issue20239