Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-115777: Fix double versionadded directives #116269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2024
Merged

gh-115777: Fix double versionadded directives #116269

merged 3 commits into from
Mar 5, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 3, 2024 •
edited by github-actions bot
Loading

@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 3, 2024
@bedevere-app bedevere-app bot mentioned this pull request Mar 3, 2024
Closed
AlexWaygood
AlexWaygood approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't personally find the status quo that confusing, but others clearly do, and I agree it's good to be consistent. I'm fine with this change

@rhettinger rhettinger removed their request for review March 4, 2024 14:00
@serhiy-storchaka serhiy-storchaka merged commit 0064dfa into python:main Mar 5, 2024
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 5, 2024
@serhiy-storchaka @miss-islington
pythongh-115777: Fix double versionadded directives (pythonGH-116269)
9fa66ed 
(cherry picked from commit 0064dfa)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 5, 2024

GH-116361 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 5, 2024
@serhiy-storchaka @miss-islington
pythongh-115777: Fix double versionadded directives (pythonGH-116269)
f1670dd 
(cherry picked from commit 0064dfa)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 5, 2024
@serhiy-storchaka serhiy-storchaka deleted the versionadded-multi branch March 5, 2024 15:42
@bedevere-app
Copy link

bedevere-app bot commented Mar 5, 2024

GH-116362 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 5, 2024
serhiy-storchaka added a commit that referenced this pull request Mar 5, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-115777: Fix double versionadded directives (GH-116269) (GH-…
0f5cd44 
…116361)

(cherry picked from commit 0064dfa)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Mar 5, 2024
@miss-islington @serhiy-storchaka
[3.11] gh-115777: Fix double versionadded directives (GH-116269) (GH-…
1b9f0d1 
…116362)

(cherry picked from commit 0064dfa)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@serhiy-storchaka @adorilson
pythongh-115777: Fix double versionadded directives (pythonGH-116269)
da4f201
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@serhiy-storchaka @diegorusso
pythongh-115777: Fix double versionadded directives (pythonGH-116269)
67a4197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @AlexWaygood @Eclips4
Morty Proxy This is a proxified and sanitized view of the page, visit original site.