-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-104711: Add security warning to the CGIHTTPRequestHandler document #115915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's a starting point, but let's focus on "only use for trusted clients". We're not going to remove it, we just don't want people expecting that it's safe to let people they don't trust access it over the internet. |
Oh I just noticed the deprecation/pending removal message directly above in the file, so I guess we are planning to remove it. There probably isn't any need to add an extra warning in that case? I don't know where the deprecation was decided, or if it was for security reasons. If so, we could just mention in the deprecation message that this should not be used for public-facing services and not add another warning. Otherwise, maybe the security section that immediately follows is a better place to mention it (and easier to backport, too). |
Maybe some people have noticed that GCI-related functionalities will be removed in the future, but they still want to use them as a temporary solution. Therefore, I think we should still add the warning to let them know there are security issues.
Currently, the warning is just below the deprecation message, and in the CGI handler section. I think it should be okay. And I think it should be a warning, so the actual page will show a red block, and it will be more noticeable. In the future, this CGI section can be wholly deleted and easily backported. |
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
LGTM, let me know when you're happy to merge. |
Thanks for the review! I think this change is ready to merge. |
Sorry, @aisk and @zooba, I could not cleanly backport this to
|
Sorry, @aisk and @zooba, I could not cleanly backport this to
|
…dler document (pythonGH-115915) (cherry picked from commit dac8ff4) Co-authored-by: AN Long <aisk@users.noreply.github.com>
GH-116235 is a backport of this pull request to the 3.12 branch. |
GH-116236 is a backport of this pull request to the 3.11 branch. |
…dler document (pythonGH-115915) (cherry picked from commit dac8ff4) Co-authored-by: AN Long <aisk@users.noreply.github.com>
Sorry, as you pointed out, these changes introduced a conflict during the backport 😂. I resolved it manually. |
…GH-115915) (cherry picked from commit dac8ff4)
…GH-115915) (cherry picked from commit dac8ff4)
Thanks! Merged now |
Also related to #104712. cc @zooba
📚 Documentation preview 📚: https://cpython-previews--115915.org.readthedocs.build/