gh-115320: Refactor get_hash_info in sysmodule.c not to swallow errors
#115321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llow errors
colesbury
reviewed
Feb 12, 2024
sobolevn
commented
Feb 12, 2024
colesbury
approved these changes
Mar 4, 2024
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 4, 2024
…llow errors (pythonGH-115321) (cherry picked from commit 207030f) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-116323 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 4, 2024
…llow errors (pythonGH-115321) (cherry picked from commit 207030f) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-116324 is a backport of this pull request to the 3.11 branch. |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…llow errors (python#115321)
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…llow errors (python#115321)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error here is unlikely, but possible in theory.
The change itself is quite straight-forward.
Skipping news, because there are no user-facing changes.
get_hash_infomight potentially swallow errors insysmodule.c#115320