-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-35722: Specify in the docs that disable_existing_loggers does not affect the root logger #11525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed an unrelated change.
vsajip
approved these changes
Jan 23, 2019
Thanks @maggyero for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
Thanks @maggyero for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 23, 2019
…s' parameter (pythonGH-11525) (cherry picked from commit f0c7436) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
GH-11655 is a backport of this pull request to the 3.7 branch. |
GH-11656 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 23, 2019
…s' parameter (pythonGH-11525) (cherry picked from commit f0c7436) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
vsajip
pushed a commit
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the package
logging
, the parameterdisable_existing_loggers
used in the functionslogging.config.dictConfig
andlogging.config.fileConfig
does not affect the root logger. More precisely, calling those functions with the parameterdisable_existing_loggers
set toTrue
orFalse
leaves the attributedisabled
of the root logger unchanged (while it sets it toTrue
for non-root loggers). So it is either a bug or the documentation should be updated. This PR updates the documentation.Illustration:
https://bugs.python.org/issue35722