Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-115167: Exclude vcruntime140_threads.dll with Visual Studio 2022 version 17.8 #115176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2024
Merged

gh-115167: Exclude vcruntime140_threads.dll with Visual Studio 2022 version 17.8 #115176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27f5537
Exclude vcruntime140_threads.dll when building with Visual Studio 202…
adang1345 Feb 8, 2024
8b707be
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions 1 Misc/NEWS.d/next/Build/2024-02-08-19-36-20.gh-issue-115167.LB9nDK.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Avoid vendoring ``vcruntime140_threads.dll`` when building with Visual Studio 2022 version 17.8.
2 changes: 1 addition & 1 deletion 2 PCbuild/pyproject.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ public override bool Execute() {
<VCRuntimeDLL Include="$(VCRuntimeDLL)" />
</ItemGroup>
<ItemGroup Condition="$(VCInstallDir) != '' and $(VCRuntimeDLL) == ''">
<VCRuntimeDLL Include="$(VCRedistDir)\Microsoft.VC*.CRT\vcruntime*.dll" />
<VCRuntimeDLL Include="$(VCRedistDir)\Microsoft.VC*.CRT\vcruntime*.dll" Exclude="$(VCRedistDir)\Microsoft.VC*.CRT\vcruntime*_threads.dll" />
</ItemGroup>

<Warning Text="vcruntime*.dll not found under $(VCRedistDir)." Condition="@(VCRuntimeDLL) == ''" />
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.