Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-107674: Improve performance of sys.settrace #114986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 28, 2024
Merged

gh-107674: Improve performance of sys.settrace #114986

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6e53f53
Improve performance of sys.settrace
gaogaotiantian Feb 4, 2024
a42d7c8
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 4, 2024
d5b1dec
Do not instrument code when tracing
gaogaotiantian Feb 5, 2024
2a1eefb
Reduce extra branch and save some operations
gaogaotiantian Feb 5, 2024
cb09c55
Change the comment to assertion
gaogaotiantian Feb 5, 2024
410a07a
Merge branch 'main' into sys-settrace-optimize
gaogaotiantian Feb 24, 2024
74d3375
Add missing instr change
gaogaotiantian Feb 26, 2024
47ff554
Do not deopt RESUME_CHECK if it's tracing
gaogaotiantian Feb 26, 2024
79f43b9
Regen executor_cases
gaogaotiantian Feb 26, 2024
0c72ada
Clean up bytecode code
gaogaotiantian Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clean up bytecode code
  • Loading branch information
@gaogaotiantian
gaogaotiantian committed Feb 27, 2024
commit 0c72adae3fd8e03323fb20126989d08ddeca98d9
16 changes: 5 additions & 11 deletions 16 Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,19 +153,13 @@ dummy_func(
int err = _Py_Instrument(_PyFrame_GetCode(frame), tstate->interp);
ERROR_IF(err, error);
next_instr = this_instr;
DISPATCH();
}
else {
if ((oparg & RESUME_OPARG_LOCATION_MASK) < RESUME_AFTER_YIELD_FROM) {
CHECK_EVAL_BREAKER();
}
this_instr->op.code = RESUME_CHECK;
}
} else {
if ((oparg & RESUME_OPARG_LOCATION_MASK) < RESUME_AFTER_YIELD_FROM) {
CHECK_EVAL_BREAKER();
}
this_instr->op.code = RESUME_CHECK;
}
if ((oparg & RESUME_OPARG_LOCATION_MASK) < RESUME_AFTER_YIELD_FROM) {
CHECK_EVAL_BREAKER();
}
this_instr->op.code = RESUME_CHECK;
}

inst(RESUME_CHECK, (--)) {
Expand Down
16 changes: 5 additions & 11 deletions 16 Python/generated_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Morty Proxy This is a proxified and sanitized view of the page, visit original site.