Clarify one-item tuple #114745
Merged
Clarify one-item tuple #114745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A 'single tuple' means 'one typle, of whatever length.
hauntsaninja
approved these changes
Jan 30, 2024
|
To me, a singleton is a class with one instance, like |
AlexWaygood
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
I agree with @hauntsaninja -- I'd remove the phrase (a.k.a. a *singleton*) (I don't think it really adds any clarity). But other than that, looks good :)
|
Agreed. The sentence flows better without the parenthetical 'singleton' comment. |
AlexWaygood
approved these changes
Jan 30, 2024
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 30, 2024
A 'single tuple' means 'one typle, of whatever length. Remove the unneeded and slight distracting parenthetical 'singleton' comment. (cherry picked from commit a1332a9) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-114757 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 30, 2024
A 'single tuple' means 'one typle, of whatever length. Remove the unneeded and slight distracting parenthetical 'singleton' comment. (cherry picked from commit a1332a9) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-114758 is a backport of this pull request to the 3.11 branch. |
terryjreedy
added a commit
that referenced
this pull request
Jan 30, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
A 'single tuple' means 'one typle, of whatever length. Remove the unneeded and slight distracting parenthetical 'singleton' comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 'single tuple' means 'one tuple, of whatever length.