-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-111800: Fix test_recursive_repr
from test_io
under WASI
#112150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm going to test the change locally on my pydebug build, then I'll merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out there are two instances of test_recursive_repr()
; second one is at line 2804.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Thanks! |
…to not recurse so deeply (pythonGH-112150)
…to not recurse so deeply (pythonGH-112150)
test_recursive_repr
fromtest_io
triggers stack overflow protections in a debug build under WASI #111800