Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.11] gh-110378: Close invalid generators in contextmanager and asynccontextmanager (GH-110499) #110589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 10, 2023

contextmanager and asynccontextmanager context managers now close an invalid
underlying generator object that yields more then one value.
(cherry picked from commit 96fed66)

Co-authored-by: Serhiy Storchaka storchaka@gmail.com

…contextmanager (pythonGH-110499)

contextmanager and asynccontextmanager context managers now close an invalid
underlying generator object that yields more then one value.
(cherry picked from commit 96fed66)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@ambv
Copy link
Contributor

ambv commented Oct 10, 2023

AttributeError: 'async_generator' object has no attribute 'ag_suspended'

Indeed, ag_suspended was only added for 3.12 in gh-79940. I will remove this part of the test for 3.11.

@ambv ambv merged commit 2b3a418 into python:3.11 Oct 10, 2023
@miss-islington miss-islington deleted the backport-96fed66-3.11 branch October 10, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.