Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

GH-109369: Add machinery for deoptimizing tier2 executors, both individually and globally. #110384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 23, 2023
Merged

GH-109369: Add machinery for deoptimizing tier2 executors, both individually and globally. #110384

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dd606ae
Add valid flag to executor objects
markshannon Sep 28, 2023
45c30d3
Add ability to invalidate executors as a result of changes to other o…
markshannon Oct 1, 2023
30844bb
Merge branch 'main' into tier2-deopt
markshannon Oct 2, 2023
79bda49
Remove unrelated change
markshannon Oct 4, 2023
76dad94
Tidier logic and add explanatory comment
markshannon Oct 4, 2023
02201f2
Merge branch 'main' into tier2-deopt
markshannon Oct 4, 2023
60306d8
Tidy up code and add test
markshannon Oct 4, 2023
0436c1a
Remove _JUMP_IF_INVALID. Save for next PR.
markshannon Oct 5, 2023
77ef658
Address some review comments
markshannon Oct 23, 2023
41f54b8
Use a single 64 bit hash function and more clearly document how the b…
markshannon Oct 23, 2023
11985ea
Fix unlinking of executors
markshannon Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix unlinking of executors
  • Loading branch information
@markshannon
markshannon committed Oct 23, 2023
commit 11985eaea519d2a4bb7d206152edf5f2db9fd625
16 changes: 8 additions & 8 deletions 16 Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,6 +1075,8 @@ link_executor(_PyExecutorObject *executor)
head->vm_data.links.next = executor;
}
executor->vm_data.linked = true;
/* executor_list_head must be first in list */
assert(interp->executor_list_head->vm_data.links.previous == NULL);
}

static void
Expand All @@ -1089,17 +1091,15 @@ unlink_executor(_PyExecutorObject *executor)
if (next != NULL) {
next->vm_data.links.previous = prev;
}
else {
if (prev == NULL) {
// Both next and prev are NULL, so this must be the list head.
PyInterpreterState *interp = PyInterpreterState_Get();
assert(interp->executor_list_head == executor);
interp->executor_list_head = executor->vm_data.links.next;
}
}
if (prev != NULL) {
prev->vm_data.links.next = next;
}
else {
// prev == NULL implies that executor is the list head
PyInterpreterState *interp = PyInterpreterState_Get();
assert(interp->executor_list_head == executor);
interp->executor_list_head = next;
}
executor->vm_data.linked = false;
}

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.