Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

GH-106529: Define POP_JUMP_IF_NONE in terms of POP_JUMP_IF_TRUE #106599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2023
Merged

GH-106529: Define POP_JUMP_IF_NONE in terms of POP_JUMP_IF_TRUE #106599

merged 3 commits into from
Jul 11, 2023

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Jul 10, 2023 •
edited by bedevere-bot
Loading

Likewise POP_JUMP_IF_NOT_NONE in terms of POP_JUMP_IF_FALSE.

@markshannon markshannon requested a review from gvanrossum July 10, 2023 14:36
@bedevere-bot bedevere-bot mentioned this pull request Jul 10, 2023
Open
11 tasks
gvanrossum
gvanrossum approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this should work with gh-106551 once that's ready.

@gvanrossum
Copy link
Member

gvanrossum commented Jul 10, 2023 •
edited
Loading

FWIW, I tried to come up with a test case for this, and finally realized these two opcodes are only emitted by compile.c for except*...

@gvanrossum
Copy link
Member

I pushed merge (since the conflict was my fault) but I'll leave it to you to land.

@markshannon markshannon merged commit c0c041a into python:main Jul 11, 2023
@markshannon markshannon deleted the micro-op-jump-if-none branch August 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markshannon @gvanrossum @bedevere-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.