-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
GH-89812: Add pathlib._PathBase
#106337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
GH-89812: Add pathlib._PathBase
#106337
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
4b29e2e
Add `pathlib._VirtualPath`
barneygale 8ce0139
Add tests for `pathlib._VirtualPath`
barneygale b850d11
Fix tests on Windows
barneygale 39bf6b3
Fix tests on Windows (take 2)
barneygale 0515dea
Fix tests on Windows (take 3)
barneygale 596016f
Fix tests on Windows (take 4)
barneygale 1a6122b
Add `tarfile.TarPath`
barneygale 6833ed8
Add docs for `tarfile.TarPath`
barneygale 4d2e8a9
Add tests for `tarfile.TarPath`
barneygale e4daac9
Merge branch 'main' into gh-89812-omgtarpath
barneygale e3f2509
Merge branch 'main' into gh-89812-omgtarpath
barneygale 508cabe
Undo changes to tarfile.
barneygale 2c56591
`_VirtualPath` --> `_PathBase`
barneygale 42fe91a
Merge branch 'main' into gh-89812-omgtarpath
barneygale 8944098
Apply suggestions from code review
barneygale b61141a
Improve _PathBase docstring
barneygale 1e462b0
Explain use of nullcontext() in comment
barneygale 6318eb7
Merge branch 'main' into gh-89812-omgtarpath
barneygale d321cad
Align and test Path/PathBase docstrings
barneygale acfc1b0
Revise `_PathBase.is_junction()`
barneygale bc82225
Make is_junction() code more consistent with other is_*() methods.
barneygale 9b6377a
Merge branch 'main' into gh-89812-omgtarpath
barneygale c3127b8
Improve `UnsupportedOperation` exception message.
barneygale 3540ae1
Slightly improve symlink loop code, exception message.
barneygale c9f0f20
Restore deleted comment in `cwd()`, expand `_scandir()` comment.
barneygale 0ee10ca
Make `_PathBase.is_junction()` immediately return false.
barneygale 17eee2f
MAX_SYMLINKS --> _MAX_SYMLINKS
barneygale c7c46bc
`return self._unsupported()` --> `self._unsupported()`
barneygale a51d7a0
WIP
barneygale 7e3729e
Undo test change.
barneygale b945cf8
Merge branch 'main' into gh-89812-omgtarpath
barneygale 703fe5c
Ensure `..` segments are resolved in non-strict mode
barneygale e5e5be5
Move symlink loop resolution test from `PosixPathTest` to `DummyPathT…
barneygale 38769a0
Add `PathBase._split_stack()` helper method.
barneygale 7c78952
Use path object as stat/link target cache key
barneygale fe57725
Optimise resolve(): skip stat() in non-strict mode if readlink() is u…
barneygale cf9c8b6
Address code review comments
barneygale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Undo test change.
This will require further refactoring in another PR.
- Loading branch information
commit 7e3729e017673a89b21d6960a37955a31ce0dd23
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.