Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Typing docs: fix typo in annotating tuples comment #106048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2023
Merged

Typing docs: fix typo in annotating tuples comment #106048

merged 1 commit into from
Jun 23, 2023

Conversation

EamonTracey
Copy link
Contributor

@EamonTracey EamonTracey commented Jun 23, 2023 •
edited
Loading

There was a recent merged PR to improve the documentation on annotating tuples. I noticed there was a typo which refers to variable y instead of z.

📚 Documentation preview 📚: https://cpython-previews--106048.org.readthedocs.build/

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jun 23, 2023
@ghost
Copy link

ghost commented Jun 23, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

AlexWaygood
AlexWaygood approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you thank you!

@AlexWaygood AlexWaygood merged commit 8ef0ee4 into python:main Jun 23, 2023
@miss-islington
Copy link
Contributor

Thanks @EamonTracey for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 23, 2023
@EamonTracey @miss-islington
Typing docs: fix typo in annotating tuples comment (pythonGH-106048)
1ba50dc 
(cherry picked from commit 8ef0ee4)

Co-authored-by: Eamon Tracey <66919574+EamonTracey@users.noreply.github.com>
@bedevere-bot
Copy link

GH-106049 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 23, 2023
@bedevere-bot
Copy link

GH-106050 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 23, 2023
@EamonTracey @miss-islington
Typing docs: fix typo in annotating tuples comment (pythonGH-106048)
5922ddb 
(cherry picked from commit 8ef0ee4)

Co-authored-by: Eamon Tracey <66919574+EamonTracey@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 23, 2023
AlexWaygood pushed a commit that referenced this pull request Jun 23, 2023
@miss-islington @EamonTracey
[3.12] Typing docs: fix typo in annotating tuples comment (GH-106048) (…
de1c090 
…#106049)

Typing docs: fix typo in annotating tuples comment (GH-106048)
(cherry picked from commit 8ef0ee4)

Co-authored-by: Eamon Tracey <66919574+EamonTracey@users.noreply.github.com>
AlexWaygood pushed a commit that referenced this pull request Jun 23, 2023
@miss-islington @EamonTracey
[3.11] Typing docs: fix typo in annotating tuples comment (GH-106048) (…
05d06e5 
…#106050)

Typing docs: fix typo in annotating tuples comment (GH-106048)
(cherry picked from commit 8ef0ee4)

Co-authored-by: Eamon Tracey <66919574+EamonTracey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EamonTracey @miss-islington @bedevere-bot @AlexWaygood
Morty Proxy This is a proxified and sanitized view of the page, visit original site.