gh-106033: Get rid of new occurrences of PyDict_GetItem and PyObject_HasAttr#106034
Merged
serhiy-storchaka merged 2 commits intopython:mainpython/cpython:mainfrom Jun 23, 2023
serhiy-storchaka:no-use-PyDict_GetItem-and-PyObject_HasAttrserhiy-storchaka/cpython:no-use-PyDict_GetItem-and-PyObject_HasAttrCopy head branch name to clipboard
Merged
gh-106033: Get rid of new occurrences of PyDict_GetItem and PyObject_HasAttr#106034serhiy-storchaka merged 2 commits intopython:mainpython/cpython:mainfrom serhiy-storchaka:no-use-PyDict_GetItem-and-PyObject_HasAttrserhiy-storchaka/cpython:no-use-PyDict_GetItem-and-PyObject_HasAttrCopy head branch name to clipboard
serhiy-storchaka merged 2 commits intopython:mainpython/cpython:mainfrom
serhiy-storchaka:no-use-PyDict_GetItem-and-PyObject_HasAttrserhiy-storchaka/cpython:no-use-PyDict_GetItem-and-PyObject_HasAttrCopy head branch name to clipboard
Conversation
…bject_HasAttr These functions are broken by design because they discard any exceptions raised inside, including MemoryError and KeyboardInterrupt. They should not be used in new code.
iritkatriel
reviewed
Jun 23, 2023
iritkatriel
reviewed
Jun 23, 2023
| } | ||
| if (!PySequence_Check(notes) || PyUnicode_Check(notes) || PyBytes_Check(notes)) { | ||
| int res = 0; | ||
| res = 0; |
Member
There was a problem hiding this comment.
is there a reason not to have this local to the block?
Member
Author
There was a problem hiding this comment.
It will hide the same named variable in the outer block. It looks errorprone, even if it does not do wrong in this case. The compiler can complain, and I would not blame it on this.
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Contributor
|
Sorry @serhiy-storchaka, I had trouble checking out the |
Contributor
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jun 23, 2023
…and PyObject_HasAttr (pythonGH-106034) These functions are broken by design because they discard any exceptions raised inside, including MemoryError and KeyboardInterrupt. They should not be used in new code.. (cherry picked from commit 1d33d53) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-106040 is a backport of this pull request to the 3.11 branch. |
|
GH-106041 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jun 23, 2023
…and PyObject_HasAttr (pythonGH-106034) These functions are broken by design because they discard any exceptions raised inside, including MemoryError and KeyboardInterrupt. They should not be used in new code. (cherry picked from commit 1d33d53) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
gpshead
pushed a commit
that referenced
this pull request
Jun 24, 2023
#106041) [3.12] gh-106033: Get rid of new occurrences of PyDict_GetItem and PyObject_HasAttr (GH-106034) These functions are broken by design because they discard any exceptions raised inside, including MemoryError and KeyboardInterrupt. They should not be used in new code. (cherry picked from commit 1d33d53)
gpshead
pushed a commit
that referenced
this pull request
Jun 24, 2023
#106040) [3.11] gh-106033: Get rid of new occurrences of PyDict_GetItem and PyObject_HasAttr (GH-106034) These functions are broken by design because they discard any exceptions raised inside, including MemoryError and KeyboardInterrupt. They should not be used in new code.. (cherry picked from commit 1d33d53)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions are broken by design because they discard any exceptions raised inside, including MemoryError and KeyboardInterrupt. They should not be used in new code.