gh-105936: Fix frozen dataclasses with slots' __setattr__ and __delattr_ #105937
Open
avboag wants to merge 3 commits intopython:mainpython/cpython:mainfrom
avboag:fixing_frozen_slots_set_del_attravboag/cpython:fixing_frozen_slots_set_del_attrCopy head branch name to clipboard
Open
gh-105936: Fix frozen dataclasses with slots' __setattr__ and __delattr_ #105937avboag wants to merge 3 commits intopython:mainpython/cpython:mainfrom avboag:fixing_frozen_slots_set_del_attravboag/cpython:fixing_frozen_slots_set_del_attrCopy head branch name to clipboard
__setattr__ and __delattr_ #105937avboag wants to merge 3 commits intopython:mainpython/cpython:mainfrom
avboag:fixing_frozen_slots_set_del_attravboag/cpython:fixing_frozen_slots_set_del_attrCopy head branch name to clipboard
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
__setattr__ and __delattr_ as laid out in issue gh-105936__setattr__ and __delattr_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that super was called
clswith the original class instead of the one generated by _add_slots.The PR moves
_add_slotsto before the generation of other methods for the dataclass that enabling the use of rightclseverywhere (currently _frozen_get_del_attr was the only place to be affected).__setattr__and__delattr__does not work. #105936