Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-104469 Convert _testcapi/exceptions to use AC #104502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 21, 2023
Merged

gh-104469 Convert _testcapi/exceptions to use AC #104502

merged 6 commits into from
May 21, 2023

Conversation

corona10
Copy link
Member

@corona10 corona10 commented May 15, 2023 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from erlend-aasland May 15, 2023 09:14
@bedevere-bot bedevere-bot mentioned this pull request May 15, 2023
Closed
@corona10 corona10 mentioned this pull request May 15, 2023
Merged
@corona10
Copy link
Member Author

@erlend-aasland @sobolevn Would you like to take a look?

sobolevn
sobolevn reviewed May 17, 2023
View reviewed changes
Modules/_testcapi/exceptions.c Show resolved Hide resolved
Modules/_testcapi/exceptions.c Show resolved Hide resolved
@corona10 corona10 requested a review from sobolevn May 18, 2023 01:01
@corona10
Copy link
Member Author

@sobolevn Thanks! Updated!

erlend-aasland
erlend-aasland reviewed May 18, 2023
View reviewed changes
Modules/_testcapi/exceptions.c Outdated Show resolved Hide resolved
Modules/_testcapi/exceptions.c Outdated Show resolved Hide resolved
@corona10 corona10 requested a review from erlend-aasland May 19, 2023 11:56
@corona10
Copy link
Member Author

@erlend-aasland Thanks! PTAL one more time!

@corona10 corona10 merged commit 2e91c7e into python:main May 21, 2023
@corona10 corona10 deleted the gh-104469-exceptions branch May 21, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@sobolevn sobolevn Awaiting requested review from sobolevn

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @sobolevn @erlend-aasland @bedevere-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.