Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-97696 Remove unnecessary check for eager_start kwarg #104188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 9, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove unnecessary check for eager_start kwarg
  • Loading branch information
jbower-fb committed May 5, 2023
commit 703e78429bd2797746b5791af2e0bfb0561228f9
6 changes: 1 addition & 5 deletions 6 Lib/asyncio/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -932,17 +932,13 @@ def callback():

def create_eager_task_factory(custom_task_constructor):

if "eager_start" not in inspect.signature(custom_task_constructor).parameters:
raise TypeError(
"Provided constructor does not support eager task execution")

def factory(loop, coro, *, name=None, context=None):
return custom_task_constructor(
coro, loop=loop, name=name, context=context, eager_start=True)


return factory


eager_task_factory = create_eager_task_factory(Task)


Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.