GH-103963: Make dis display names of args for intrinsics opcodes #104029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good, a few comments. You'll also have to add a NEWS entry.
iritkatriel
reviewed
May 1, 2023
Contributor
Author
|
@iritkatriel @JelleZijlstra I've reviewed your comments and updated the PR. Please let me know if you see anything else or if I should convert to normal PR. |
Member
|
I'll give Irit some time to take another look, but I think this is ready to merge. |
iritkatriel
reviewed
May 2, 2023
Include/internal/pycore_intrinsics.h
Outdated
|
|
||
|
|
||
| /* Binary Functions: */ | ||
| #define INTRINSIC_INVALID 0 |
Member
There was a problem hiding this comment.
Looks like INTRINSIC_INVALID is defined twice?
Contributor
Author
There was a problem hiding this comment.
Updated to differentiate between invalid for the two CALL_INTRINSIC_* opcodes.
iritkatriel
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the dis module display the names of the args for opcodes
CALL_INTRINSIC_*.Fixes #103963