Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-102213: Optimize the performance of __getattr__ #103761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 1, 2023
Merged

gh-102213: Optimize the performance of __getattr__ #103761

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ac81fd6
Optimize the performance of `__getattr__`
sunmy2019 Apr 24, 2023
f6c3704
Update Objects/typeobject.c
sunmy2019 Apr 24, 2023
91aa490
Update Objects/typeobject.c
sunmy2019 Apr 24, 2023
c90be9d
Merge branch 'main' into gh-102248-corrected
ambv Apr 25, 2023
c3aebf6
add test case for gh-103551
sunmy2019 Apr 25, 2023
75d9a70
Update Objects/typeobject.c
sunmy2019 Apr 27, 2023
a3d75af
📜🤖 Added by blurb_it.
blurb-it[bot] May 1, 2023
29155b4
Merge remote-tracking branch 'upstream/main' into pr/103761
Fidget-Spinner May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Objects/typeobject.c 
Co-authored-by: Kirill <80244920+Eclips4@users.noreply.github.com>
  • Loading branch information
@sunmy2019 @Eclips4
sunmy2019 and Eclips4 authored Apr 24, 2023
commit f6c37040087bc7e2c977b691a1039ce1b17406e7
2 changes: 1 addition & 1 deletion 2 Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8259,7 +8259,7 @@ _Py_slot_tp_getattr_hook(PyObject *self, PyObject *name)
((PyWrapperDescrObject *)getattribute)->d_wrapped ==
(void *)PyObject_GenericGetAttr)) {
res = _PyObject_GenericGetAttrWithDict(self, name, NULL, 1);
/* if no error has occureed, then it must be suppressed by us */
/* if no error has occured, then it must be suppressed by us */
sunmy2019 marked this conversation as resolved.
Show resolved Hide resolved
if (res == NULL && !PyErr_Occurred()) {
res = call_attribute(self, getattr, name);
}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.