Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-103000: Optimise dataclasses asdict/astuple for common types #103005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 10, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/dataclasses.py
Improve comment describing _ATOMIC_TYPES

Co-authored-by: Carl Meyer <carl@oddbird.net>
  • Loading branch information
DavidCEllis and carljm authored Mar 24, 2023
commit b6d8a6f7b5f04fe16e0853ce2c95c583cd289493
4 changes: 2 additions & 2 deletions 4 Lib/dataclasses.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,8 @@ def __repr__(self):
# https://bugs.python.org/issue33453 for details.
_MODULE_IDENTIFIER_RE = re.compile(r'^(?:\s*(\w+)\s*\.)?\s*(\w+)')

# Types for which deepcopy(obj) is known to return obj unmodified
# Used to skip deepcopy in asdict and astuple for performance
# Atomic immutable types which don't require any recursive handling and for which deepcopy
# returns the same object. We can provide a fast-path for these types in asdict and astuple.
_ATOMIC_TYPES = {
# Common JSON Serializable types
types.NoneType,
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.