-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-103092: Isolate _pickle
#102982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
gh-103092: Isolate _pickle
#102982
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
88455f2
try to port pickle to multi-stage init
koubaa 7a6189a
remove global state access
koubaa ce32a69
finish port
koubaa bffb49b
Convert PData type to heap type and add it to state
erlend-aasland 5fcce82
Convert PicklerMemoProxyType to heap type and add it to state
erlend-aasland 3203188
WIP
erlend-aasland f1ce8fb
Fixup dealloc and traverse functions
erlend-aasland a6679ff
State is unused in AC
erlend-aasland 35025d2
Adjust NEWS
erlend-aasland d8efd22
Update globals-to-fix
erlend-aasland 9fcc0d9
Adjust get-state helpers
erlend-aasland add3ba5
Reduce diff size; remove stylic changes
erlend-aasland b915f06
Nit
erlend-aasland 223e143
Revert type name changes
erlend-aasland 288a764
fixup! Revert type name changes
erlend-aasland 0551d52
Add CREATE_TYPE helper
erlend-aasland ae0f6af
Update Misc/NEWS.d/next/Core and Builtins/2020-07-04-09-04-41.bpo-163…
kumaraditya303 82fe129
Pull in main
erlend-aasland 6c1621e
Address review: in memo proxy types set tp_hash to PyObject_HashNotIm…
erlend-aasland ffc25ad
Address review: find state by module def in get/set methods
erlend-aasland e363fed
Address review
erlend-aasland 233e102
Pull in main
erlend-aasland bb397fe
Address review: make memo types immutable and add tests
erlend-aasland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Adjust NEWS
- Loading branch information
commit 35025d26692a4d92b7380fe5c9da0bf7d6d4c049
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
Misc/NEWS.d/next/Core and Builtins/2020-07-04-09-04-41.bpo-1635741.ZsP31Y.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
Port :mod:`_pickle` to multiphase initialization | ||
Adapt :mod:`_pickle` to :pep:`687`. Patch by Mohamed Koubaa and Erlend Aasland. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.