Store correct birthtime value

python · zooba · Mar 16, 2023 · Feb 22, 2023 · Feb 22, 2023 · Feb 22, 2023
commit de1146878ba52f5791c3f12a666eb1ac57effcde
diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py
@@ -556,6 +556,15 @@ def trunc(x): return x
            nanosecondy = getattr(result, name + "_ns") // 10000
            self.assertAlmostEqual(floaty, nanosecondy, delta=2)

+        # Ensure both birthtime and birthtime_ns roughly agree, if present
+        try:
+            floaty = int(result.st_birthtime * 100000)
+            nanosecondy = result.st_birthtime_ns // 10000
+        except AttributeError:
+            pass
+        else:
+            self.assertAlmostEqual(floaty, nanosecondy, delta=2)
+
        try:
            result[200]
            self.fail("No exception raised")

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
@@ -2528,7 +2528,7 @@ _pystat_fromstructstat(PyObject *module, STRUCT_STAT *st)
                                val);
    }
 #elif defined(MS_WINDOWS)
-    fill_time(module, v, ST_BIRTHTIME_IDX, -1, ST_BIRTHTIME_NS_IDX,
+    fill_time(module, v, -1, ST_BIRTHTIME_IDX, ST_BIRTHTIME_NS_IDX,
              st->st_birthtime, st->st_birthtime_nsec);
 #endif
 #ifdef HAVE_STRUCT_STAT_ST_FLAGS