Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update http.cookiejar document for cookie object attributes #101885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 22, 2024
Merged

Update http.cookiejar document for cookie object attributes #101885

merged 3 commits into from
Feb 22, 2024

Conversation

NewUserHa
Copy link
Contributor

The document misses the Cookie.domain.

BTW, Cookie.secure is 1 instead of True in repr sometimes,
and rest is missing in the document too, but can't find it in the rfc2965, should add it?

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Feb 13, 2023
serhiy-storchaka
serhiy-storchaka reviewed Feb 20, 2024
View reviewed changes
Doc/library/http.cookiejar.rst Outdated Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) February 22, 2024 19:03
@serhiy-storchaka serhiy-storchaka merged commit a385942 into python:main Feb 22, 2024
@miss-islington-app
Copy link

Thanks @NewUserHa for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 22, 2024
@NewUserHa @miss-islington
Update http.cookiejar document for cookie object attributes (pythonGH…
5812fbc 
…-101885)

(cherry picked from commit a385942)

Co-authored-by: NewUserHa <32261870+NewUserHa@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 22, 2024

GH-115833 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 22, 2024
@NewUserHa @miss-islington
Update http.cookiejar document for cookie object attributes (pythonGH…
91c4be6 
…-101885)

(cherry picked from commit a385942)

Co-authored-by: NewUserHa <32261870+NewUserHa@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 22, 2024
@bedevere-app
Copy link

bedevere-app bot commented Feb 22, 2024

GH-115834 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 22, 2024
willingc pushed a commit that referenced this pull request Feb 23, 2024
@miss-islington @NewUserHa
[3.11] Update http.cookiejar document for cookie object attributes (G…
7c2e1b2 
…H-101885) (#115834)

Update http.cookiejar document for cookie object attributes (GH-101885)
(cherry picked from commit a385942)

Co-authored-by: NewUserHa <32261870+NewUserHa@users.noreply.github.com>
willingc pushed a commit that referenced this pull request Feb 23, 2024
@miss-islington @NewUserHa
[3.12] Update http.cookiejar document for cookie object attributes (G…
71b75f6 
…H-101885) (#115833)

Update http.cookiejar document for cookie object attributes (GH-101885)
(cherry picked from commit a385942)

Co-authored-by: NewUserHa <32261870+NewUserHa@users.noreply.github.com>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@NewUserHa @woodruffw
Update http.cookiejar document for cookie object attributes (pythonGH…
d935195 
…-101885)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@NewUserHa @diegorusso
Update http.cookiejar document for cookie object attributes (pythonGH…
9b7fb30 
…-101885)
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@NewUserHa @LukasWoodtli
Update http.cookiejar document for cookie object attributes (pythonGH…
2032f52 
…-101885)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NewUserHa @serhiy-storchaka @bedevere-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.