Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-95299: Stop installing setuptools as a part of ensurepip and venv #101039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 18, 2023
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
001ee43
Use environment variables to pass data into test setup script
pradyunsg Jan 14, 2023
b8421a1
Update test_cppext to stop invoking setuptools-based script as a CLI
pradyunsg Jan 14, 2023
9d343f2
Stop installing setuptools as a part of ensurepip and venv
pradyunsg Sep 24, 2022
4a51332
Correct the name of step in GitHub Action
pradyunsg Jan 15, 2023
e0c53df
Drop most remaining references to `easy_install`
pradyunsg Feb 3, 2023
4c8e6be
fixup! Update test_cppext to stop invoking setuptools-based script as…
pradyunsg Feb 3, 2023
b489e52
fixup! Update test_cppext to stop invoking setuptools-based script as…
pradyunsg Feb 3, 2023
f308da4
Add a "What's New" entry for the setuptools removal
pradyunsg Feb 3, 2023
9579a3e
fixup! Add a "What's New" entry for the setuptools removal
pradyunsg Feb 3, 2023
0e2b55e
fixup! Add a "What's New" entry for the setuptools removal
pradyunsg Feb 3, 2023
0b8f384
Update Doc/whatsnew/3.12.rst
pradyunsg Feb 4, 2023
1262bee
Merge branch 'main' into remove-setuptools-ensurepip
arhadthedev Feb 23, 2023
bcda4cd
Merge branch 'main' into remove-setuptools-ensurepip
pradyunsg Feb 26, 2023
e19784d
Update "Creating virtual environments" section to drop reference
pradyunsg Apr 4, 2023
ea1bcea
Use the style suggested in review
pradyunsg Apr 4, 2023
5275f93
Use dirname on the absolute path
pradyunsg Apr 4, 2023
5c3ce99
Locate cppextdata with plain filesystem lookups
pradyunsg Apr 4, 2023
375b5c6
Merge branch 'main' into remove-setuptools-ensurepip
pradyunsg Apr 17, 2023
991d066
bundled pip -> bundled wheels
pradyunsg Apr 17, 2023
ebf6c3b
Unbreak `test_cppext`
pradyunsg Apr 17, 2023
b83cf9f
:art:
pradyunsg Apr 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into remove-setuptools-ensurepip
  • Loading branch information
pradyunsg committed Apr 17, 2023
commit 375b5c67adfa0306a5e68d282f4270600175ada4
14 changes: 9 additions & 5 deletions 14 Lib/test/test_cppext.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
# gh-91321: Build a basic C++ test extension to check that the Python C API is
# compatible with C++ and does not emit C++ compiler warnings.
import os.path
try:
import ssl
except ImportError:
ssl = None
import shutil
import sys
import unittest
import subprocess
Expand Down Expand Up @@ -85,9 +82,16 @@ def run_cmd(operation, cmd):
self.fail(
f"{operation} failed with exit code {proc.returncode}")

cmd = [python, '-X', 'dev',
'-m', 'pip', 'install',
support.findfile('setuptools-67.6.1-py3-none-any.whl'),
support.findfile('wheel-0.40.0-py3-none-any.whl')]
run_cmd('Install build dependencies', cmd)

# Build and install the C++ extension
cmd = [python, '-X', 'dev',
'-m', 'pip', 'install', PKG_CPPEXTDATA]
'-m', 'pip', 'install', '--no-build-isolation',
os.path.abspath(pkg_dir)]
run_cmd('Install', cmd)

# Do a reference run. Until we test that running python
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.