gh-88696: clean up dead argument to compiler_make_closure#100806
Merged
markshannon merged 2 commits intopython:mainpython/cpython:mainfrom Jan 7, 2023
Merged
gh-88696: clean up dead argument to compiler_make_closure#100806markshannon merged 2 commits intopython:mainpython/cpython:mainfrom
markshannon merged 2 commits intopython:mainpython/cpython:mainfrom
Conversation
Member
|
You also need to remove the variable declarations |
Member
|
Looks good. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#26941 left some dead code in the compiler. The
qualnameargument tocompiler_make_closureis now unused,and several callers go to some trouble to make a new reference to it just for that call. Remove that argument and the extra caller code required to provide it.
Closes #88696