Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove redundant fields from basicblock: b_nofallthrough, b_exit, b_return #93444

Copy link
Copy link
Closed
@iritkatriel

Description

@iritkatriel
Issue body actions

The fields b_nofallthrough, b_exit, b_return in the compiler's basicblock can be easily calculated form the opcode of the last instruction in the block, so we can remove them.

This change is in line with our general move to simplify the compiler front end by not making it calculate things that the backend can deduce. It increases safety because the cached values need to be kept correct through transformations/optimisations of the block, and this adds opportunities for bugs.

Metadata

Metadata

Assignees

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.