test_interpreters misses tests with all pickle protocols #136285
Description
There are multiple places in test_interpreters where pickle only tests the default protocol.
Like:
cpython/Lib/test/test_interpreters/test_api.py
Lines 413 to 417 in 8ac7613
I guess that we can improve the tests with more protocols.
But, when I do that protocols 0 and 1 fail for all objects.
I decided to just limit the tests for now, because I am not sure if this is actually an intended behavior:
======================================================================
ERROR: test_pickle (test.test_interpreters.test_channels.TestRecvChannelAttrs.test_pickle) (protocol=0)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/sobolev/Desktop/cpython/Lib/test/test_interpreters/test_channels.py", line 128, in test_pickle
self.assertEqual(unpickled, ch)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
File "/Users/sobolev/Desktop/cpython/Lib/unittest/case.py", line 925, in assertEqual
assertion_func(first, second, msg=msg)
~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/sobolev/Desktop/cpython/Lib/unittest/case.py", line 915, in _baseAssertEqual
if not first == second:
^^^^^^^^^^^^^^^
File "/Users/sobolev/Desktop/cpython/Lib/test/support/channels.py", line 105, in __eq__
return other._id == self._id
^^^^^^^^
AttributeError: 'RecvChannel' object has no attribute '_id'. Did you mean: 'id'?
======================================================================
ERROR: test_pickle (test.test_interpreters.test_channels.TestRecvChannelAttrs.test_pickle) (protocol=1)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/sobolev/Desktop/cpython/Lib/test/test_interpreters/test_channels.py", line 128, in test_pickle
self.assertEqual(unpickled, ch)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
File "/Users/sobolev/Desktop/cpython/Lib/unittest/case.py", line 925, in assertEqual
assertion_func(first, second, msg=msg)
~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/sobolev/Desktop/cpython/Lib/unittest/case.py", line 915, in _baseAssertEqual
if not first == second:
^^^^^^^^^^^^^^^
File "/Users/sobolev/Desktop/cpython/Lib/test/support/channels.py", line 105, in __eq__
return other._id == self._id
^^^^^^^^
AttributeError: 'RecvChannel' object has no attribute '_id'. Did you mean: 'id'?
======================================================================
ERROR: test_pickle (test.test_interpreters.test_channels.TestSendChannelAttrs.test_pickle) (protocol=0)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/sobolev/Desktop/cpython/Lib/test/test_interpreters/test_channels.py", line 161, in test_pickle
self.assertEqual(unpickled, ch)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
File "/Users/sobolev/Desktop/cpython/Lib/unittest/case.py", line 925, in assertEqual
assertion_func(first, second, msg=msg)
~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/sobolev/Desktop/cpython/Lib/unittest/case.py", line 915, in _baseAssertEqual
if not first == second:
^^^^^^^^^^^^^^^
File "/Users/sobolev/Desktop/cpython/Lib/test/support/channels.py", line 105, in __eq__
return other._id == self._id
^^^^^^^^
AttributeError: 'SendChannel' object has no attribute '_id'. Did you mean: 'id'?
======================================================================
ERROR: test_pickle (test.test_interpreters.test_channels.TestSendChannelAttrs.test_pickle) (protocol=1)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/sobolev/Desktop/cpython/Lib/test/test_interpreters/test_channels.py", line 161, in test_pickle
self.assertEqual(unpickled, ch)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
File "/Users/sobolev/Desktop/cpython/Lib/unittest/case.py", line 925, in assertEqual
assertion_func(first, second, msg=msg)
~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/sobolev/Desktop/cpython/Lib/unittest/case.py", line 915, in _baseAssertEqual
if not first == second:
^^^^^^^^^^^^^^^
File "/Users/sobolev/Desktop/cpython/Lib/test/support/channels.py", line 105, in __eq__
return other._id == self._id
^^^^^^^^
AttributeError: 'SendChannel' object has no attribute '_id'. Did you mean: 'id'?
======================================================================
FAIL: test_pickle (test.test_interpreters.test_api.InterpreterObjectTests.test_pickle) (protocol=0)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/sobolev/Desktop/cpython/Lib/test/test_interpreters/test_api.py", line 419, in test_pickle
self.assertEqual(unpickled, interp)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: <concurrent.interpreters.Interpreter object at 0x102928d60> != Interpreter(22)
======================================================================
FAIL: test_pickle (test.test_interpreters.test_api.InterpreterObjectTests.test_pickle) (protocol=1)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/sobolev/Desktop/cpython/Lib/test/test_interpreters/test_api.py", line 419, in test_pickle
self.assertEqual(unpickled, interp)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: <concurrent.interpreters.Interpreter object at 0x10293e9e0> != Interpreter(22)
======================================================================
FAIL: test_pickle (test.test_interpreters.test_queues.QueueTests.test_pickle) (protocol=0)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/sobolev/Desktop/cpython/Lib/test/test_interpreters/test_queues.py", line 195, in test_pickle
self.assertEqual(unpickled, queue)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
AssertionError: <concurrent.interpreters._queues.Queue object at 0x1026fc8d0> != Queue(17)
======================================================================
FAIL: test_pickle (test.test_interpreters.test_queues.QueueTests.test_pickle) (protocol=1)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/sobolev/Desktop/cpython/Lib/test/test_interpreters/test_queues.py", line 195, in test_pickle
self.assertEqual(unpickled, queue)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
AssertionError: <concurrent.interpreters._queues.Queue object at 0x102709800> != Queue(17)
----------------------------------------------------------------------
Ran 165 tests in 6.277s
Linked PRs
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Tests in the Lib/test dirTests in the Lib/test dirSubprocess issues.Subprocess issues.An unexpected behavior, bug, or errorAn unexpected behavior, bug, or error