Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove unused code related to the removed BINARY_SUBSCR instruction #131306

New issue
Copy link
New issue
Copy link
Closed
Closed
Remove unused code related to the removed BINARY_SUBSCR instruction#131306
Copy link
Assignees
tomasr8
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancementA feature request or enhancement
@tomasr8

Description

@tomasr8
tomasr8
opened on Mar 15, 2025
Issue body actions

BINARY_SUBSCR was replaced with BINARY_OP and the NB_SUBSCR oparg in #129700 but there is still some code related to BINARY_SUBSCR that I believe can be removed. Some examples:

cpython/Include/internal/pycore_code.h

Lines 121 to 125 in e82c2ca

typedef struct {
_Py_BackoffCounter counter;
} _PyBinarySubscrCache;
#define INLINE_CACHE_ENTRIES_BINARY_SUBSCR CACHE_ENTRIES(_PyBinarySubscrCache)

cpython/Lib/opcode.py

Lines 66 to 68 in e82c2ca

"BINARY_SUBSCR": {
"counter": 1,
},

Linked PRs

Metadata

Metadata

Assignees

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancementA feature request or enhancement

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions
    Morty Proxy This is a proxified and sanitized view of the page, visit original site.