Leftover code in sysconfig.expand_makefile_vars

Bug report

Bug description:

I think there is some leftover code in sysconfig.expand_makefile_vars (4a53a39):

Lines 727 to 734 in 4dade05

    
           while True: 
        
               m = re.search(_findvar1_rx, s) or re.search(_findvar2_rx, s) 
        
               if m: 
        
                   (beg, end) = m.span() 
        
                   s = s[0:beg] + vars.get(m.group(1)) + s[end:] 
        
               else: 
        
                   break 
        
           return s

The _findvar1_rx and _findvar2_rx variables are not declared at all (they were moved to sysconfig/__main__.py). Since the function is publicly named (but not exported nor documented), I prefer backporting the changes of #110785, namely re-use the patterns as is.

cc @FFY00

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Leftover code in `sysconfig.expand_makefile_vars` #128978

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	while True:
	m = re.search(_findvar1_rx, s) or re.search(_findvar2_rx, s)
	if m:
	(beg, end) = m.span()
	s = s[0:beg] + vars.get(m.group(1)) + s[end:]
	else:
	break
	return s

Search code, repositories, users, issues, pull requests...

Uh oh!

Leftover code in sysconfig.expand_makefile_vars #128978

Description

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

Leftover code in `sysconfig.expand_makefile_vars` #128978