Extract ZipInfo for archive functionality

In #123354, I found the need to copy code from zipfile into the test:

cpython/Lib/test/test_zipfile/_path/test_path.py

Lines 662 to 676 in 9e108b8

    
               def for_name(cls, name, archive): 
        
                   """ 
        
                   Construct the same way that ZipFile.writestr does. 
        
                   TODO: extract this functionality and re-use 
        
                   """ 
        
                   self = cls(filename=name, date_time=time.localtime(time.time())[:6]) 
        
                   self.compress_type = archive.compression 
        
                   self.compress_level = archive.compresslevel 
        
                   if self.filename.endswith('/'):  # pragma: no cover 
        
                       self.external_attr = 0o40775 << 16  # drwxrwxr-x 
        
                       self.external_attr |= 0x10  # MS-DOS directory flag 
        
                   else: 
        
                       self.external_attr = 0o600 << 16  # ?rw------- 
        
                   return self

Let's instead extract that functionality in the zipfile module for re-use in the test (before it starts diverging).

Linked PRs

gh-123424: add ZipInfo._for_archive to set suitable default properties #123429

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Extract ZipInfo for archive functionality #123424

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	def for_name(cls, name, archive):
	"""
	Construct the same way that ZipFile.writestr does.

	TODO: extract this functionality and re-use
	"""
	self = cls(filename=name, date_time=time.localtime(time.time())[:6])
	self.compress_type = archive.compression
	self.compress_level = archive.compresslevel
	if self.filename.endswith('/'): # pragma: no cover
	self.external_attr = 0o40775 << 16 # drwxrwxr-x
	self.external_attr \|= 0x10 # MS-DOS directory flag
	else:
	self.external_attr = 0o600 << 16 # ?rw-------
	return self

Search code, repositories, users, issues, pull requests...

Uh oh!

Extract ZipInfo for archive functionality #123424

Description

Linked PRs

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions